fresh-borzoni commented on PR #28090:
URL: https://github.com/apache/flink/pull/28090#issuecomment-4649928935
Sorry this sat so long, finally got back to it. Thanks @xuyangzhong and
@featzhang for the detailed review.
Rebased on master and pushed an update, PTAL 🙏
I noticed a gap of my own related to multi-joins: a non-equi predicate can
sit in an ON clause rather than the post-join filter and still gets evaluated
at runtime, so dropping UB there leaks a phantom row. Added a guard for it,
skipping the common join-key equalities since those are already handled by the
join-key logic.
This is the same area as #27372 (upsert-key enrichment via equi-join
equivalences) and they complement each other: that PR's equivalences feed
straight into these guards, and the multijoin common-key skip here is really a
local version of the same idea. After equivalence-metadata route @xuyangzhong
suggested in #27372 , these guards could just consume that in a follow-up and
the special-case drops out. Keeping them independent for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
