snuyanzin commented on code in PR #28170:
URL: https://github.com/apache/flink/pull/28170#discussion_r3416638298
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/subquery/SubQueryAntiJoinTest.scala:
##########
@@ -737,7 +737,7 @@ class SubQueryAntiJoinTest extends SubQueryTestBase {
// TODO some bugs in SubQueryRemoveRule
// the result RelNode (LogicalJoin(condition=[=($1, $11)],
joinType=[left]))
// after SubQueryRemoveRule is unexpected
- assertThatExceptionOfType(classOf[AssertionError])
+ assertThatExceptionOfType(classOf[NullPointerException])
Review Comment:
The reason is this change https://issues.apache.org/jira/browse/CALCITE-6552
especially this
https://github.com/apache/calcite/pull/3939/changes#diff-d391d0f9b1eaeb21e26fb2b96df125cafa58770e168dd55c5d3c8193e2def789R1344
where
this line
```java
assert currentRel != null;
```
was replaced with
```java
requireNonNull(currentRel, "currentRel");
```
btw. If I remember correctly these queries will be fixed with upgrade to
1.40 or 1.41
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/subquery/SubQuerySemiJoinTest.scala:
##########
@@ -1711,7 +1679,7 @@ class SubQuerySemiJoinTest extends SubQueryTestBase {
// TODO some bugs in SubQueryRemoveRule
// the result RelNode (LogicalJoin(condition=[=($1, $8)],
joinType=[left]))
// after SubQueryRemoveRule is unexpected
- assertThatExceptionOfType(classOf[AssertionError])
+ assertThatExceptionOfType(classOf[NullPointerException])
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
