snuyanzin commented on code in PR #28170:
URL: https://github.com/apache/flink/pull/28170#discussion_r3416649669
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/agg/OverAggregateTest.xml:
##########
@@ -52,22 +52,22 @@ FROM MyTable
</Resource>
<Resource name="ast">
<![CDATA[
-LogicalProject(EXPR$0=[CASE(>(COUNT($0) OVER (PARTITION BY $1 ORDER BY $0
NULLS FIRST), 0), $SUM0($0) OVER (PARTITION BY $1 ORDER BY $0 NULLS FIRST),
null:INTEGER)], EXPR$1=[MAX($0) OVER (PARTITION BY $1 ORDER BY $2 NULLS
FIRST)], EXPR$2=[CAST(/(CASE(>(COUNT($0) OVER (PARTITION BY $2 ORDER BY $0
NULLS FIRST), 0), $SUM0($0) OVER (PARTITION BY $2 ORDER BY $0 NULLS FIRST),
null:INTEGER), COUNT($0) OVER (PARTITION BY $2 ORDER BY $0 NULLS
FIRST))):INTEGER], EXPR$3=[RANK() OVER (PARTITION BY $1 ORDER BY $0 NULLS
FIRST)], EXPR$4=[MIN($0) OVER (PARTITION BY $2 ORDER BY $0 NULLS FIRST)])
+LogicalProject(EXPR$0=[CASE(>(COUNT($0) OVER (PARTITION BY $1 ORDER BY $0
NULLS FIRST), 0), SUM($0) OVER (PARTITION BY $1 ORDER BY $0 NULLS FIRST),
null:INTEGER)], EXPR$1=[MAX($0) OVER (PARTITION BY $1 ORDER BY $2 NULLS
FIRST)], EXPR$2=[CAST(/(CASE(>(COUNT($0) OVER (PARTITION BY $2 ORDER BY $0
NULLS FIRST), 0), SUM($0) OVER (PARTITION BY $2 ORDER BY $0 NULLS FIRST),
null:INTEGER), COUNT($0) OVER (PARTITION BY $2 ORDER BY $0 NULLS
FIRST))):INTEGER], EXPR$3=[RANK() OVER (PARTITION BY $1 ORDER BY $0 NULLS
FIRST)], EXPR$4=[MIN($0) OVER (PARTITION BY $2 ORDER BY $0 NULLS FIRST)])
Review Comment:
the only change here `$SUM0` replaced with `SUM` as result of this global
change https://issues.apache.org/jira/browse/CALCITE-6020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
