Shekharrajak commented on code in PR #271:
URL: 
https://github.com/apache/flink-connector-kafka/pull/271#discussion_r3448013655


##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaShareEosPipelineITCase.java:
##########
@@ -0,0 +1,1086 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kafka.sink;
+
+import org.apache.flink.api.common.functions.RichMapFunction;
+import org.apache.flink.api.common.state.CheckpointListener;
+import org.apache.flink.api.common.state.ListState;
+import org.apache.flink.api.common.state.ListStateDescriptor;
+import org.apache.flink.api.connector.sink2.Committer;
+import org.apache.flink.api.connector.sink2.CommitterInitContext;
+import org.apache.flink.api.connector.sink2.WriterInitContext;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.RestartStrategyOptions;
+import org.apache.flink.connector.base.DeliveryGuarantee;
+import org.apache.flink.connector.kafka.share.ShareAckCommittable;
+import 
org.apache.flink.connector.kafka.sink.internal.FlinkKafkaInternalProducer;
+import org.apache.flink.connector.kafka.sink.internal.KafkaCommitter;
+import 
org.apache.flink.connector.kafka.source.reader.transaction.KafkaShareAckTransactionManager;
+import 
org.apache.flink.connector.kafka.source.reader.transaction.ShareAckTransactionClient;
+import 
org.apache.flink.connector.kafka.source.reader.transaction.ShareAckTransactionHandle;
+import org.apache.flink.connector.kafka.testutils.TestKafkaContainer;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.core.testutils.CommonTestUtils;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.streaming.api.checkpoint.CheckpointedFunction;
+import org.apache.flink.streaming.api.connector.sink2.CommittableMessage;
+import org.apache.flink.streaming.api.connector.sink2.StandardSinkTopologies;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import 
org.apache.flink.streaming.api.functions.source.legacy.RichParallelSourceFunction;
+import org.apache.flink.streaming.api.functions.source.legacy.SourceFunction;
+import org.apache.flink.test.util.MiniClusterWithClientResource;
+
+import org.apache.kafka.clients.admin.AdminClient;
+import org.apache.kafka.clients.admin.AlterConfigOp;
+import org.apache.kafka.clients.admin.ConfigEntry;
+import org.apache.kafka.clients.admin.ListShareGroupOffsetsOptions;
+import org.apache.kafka.clients.admin.ListShareGroupOffsetsResult;
+import org.apache.kafka.clients.admin.ListShareGroupOffsetsSpec;
+import org.apache.kafka.clients.admin.NewTopic;
+import org.apache.kafka.clients.admin.SharePartitionOffsetInfo;
+import org.apache.kafka.clients.consumer.AcknowledgeType;
+import org.apache.kafka.clients.consumer.ConsumerConfig;
+import org.apache.kafka.clients.consumer.ConsumerRecord;
+import org.apache.kafka.clients.consumer.ConsumerRecords;
+import org.apache.kafka.clients.consumer.KafkaConsumer;
+import org.apache.kafka.clients.consumer.KafkaShareConsumer;
+import org.apache.kafka.clients.producer.KafkaProducer;
+import org.apache.kafka.clients.producer.ProducerConfig;
+import org.apache.kafka.clients.producer.ProducerRecord;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.config.ConfigResource;
+import org.apache.kafka.common.config.ConfigResource.Type;
+import org.apache.kafka.common.serialization.ByteArrayDeserializer;
+import org.apache.kafka.common.serialization.ByteArraySerializer;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Assumptions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
+import org.junit.jupiter.api.parallel.ResourceLock;
+import org.testcontainers.utility.DockerImageName;
+
+import javax.annotation.Nullable;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.lang.reflect.Method;
+import java.nio.charset.StandardCharsets;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.Queue;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+@Timeout(240)
+@ResourceLock("KafkaTestBase")
+class KafkaShareEosPipelineITCase {
+
+    private static final String BOOTSTRAP_SERVERS_PROPERTY =
+            "flink.kafka.share.it.bootstrap.servers";
+    private static final String KAFKA_IMAGE_PROPERTY = 
"flink.kafka.share.it.image";
+    private static final String SHARE_ACK_MODE_CONFIG = 
"share.acknowledgement.mode";
+    private static final String SHARE_AUTO_OFFSET_RESET_CONFIG = 
"share.auto.offset.reset";
+    private static final Duration POLL_TIMEOUT = Duration.ofMillis(500);
+    private static final Duration WAIT_TIMEOUT = Duration.ofSeconds(45);
+    private static final int PARALLELISM = 4;
+    private static final int NO_CHECKPOINT = -1;
+
+    private static final Map<String, FlinkKafkaInternalProducer<byte[], 
byte[]>>
+            SOURCE_ACK_PRODUCERS = new ConcurrentHashMap<>();
+    private static final Set<String> SINK_COMMITTED_SHARE_ACKS = 
ConcurrentHashMap.newKeySet();
+    private static final Set<String> COMMITTED_SHARE_ACKS = 
ConcurrentHashMap.newKeySet();
+    private static final Queue<String> COMMIT_EVENTS = new 
ConcurrentLinkedQueue<>();
+
+    private TestKafkaContainer kafkaContainer;
+
+    @AfterEach
+    void tearDown() {
+        SOURCE_ACK_PRODUCERS.values()
+                .forEach(
+                        producer -> {
+                            try {
+                                producer.close();
+                            } catch (Exception ignored) {
+                            }
+                        });
+        SOURCE_ACK_PRODUCERS.clear();
+        SINK_COMMITTED_SHARE_ACKS.clear();
+        COMMITTED_SHARE_ACKS.clear();
+        COMMIT_EVENTS.clear();
+        if (kafkaContainer != null) {
+            kafkaContainer.stop();
+            kafkaContainer = null;
+        }
+    }
+
+    @Test
+    void 
testShareSourceOperatorToKafkaSinkExactlyOnceCommitsSinkBeforeShareAcks()
+            throws Exception {
+        int partitionCount = 6;
+        int recordsPerPartition = 5;
+        int expectedRecords = partitionCount * recordsPerPartition;
+        SharePipelineContext context = createContext(partitionCount);
+        produceToPartitions(
+                context.bootstrapServers, context.inputTopic, partitionCount, 
recordsPerPartition);
+
+        Configuration flinkConfiguration = new Configuration();
+        flinkConfiguration.set(RestartStrategyOptions.RESTART_STRATEGY, 
"none");
+        MiniClusterWithClientResource miniCluster =

Review Comment:
   this is basically to setup like : 
   
   ```
    MiniCluster: 2 TaskManagers, 2 slots each
     parallelism: 4
     input topic: 6 partitions, 30 records
     output topic: 6 partitions
     source -> rebalance -> map -> Kafka EOS sink
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to