Shekharrajak commented on code in PR #271:
URL:
https://github.com/apache/flink-connector-kafka/pull/271#discussion_r3483184856
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/transaction/ShareAckTransactionClient.java:
##########
@@ -29,7 +29,7 @@ public interface ShareAckTransactionClient extends
AutoCloseable {
void stageAcknowledgements(ShareAckTransactionHandle transaction)
throws IOException, InterruptedException;
- void preCommit(ShareAckTransactionHandle transaction) throws IOException,
InterruptedException;
+ String preCommit(ShareAckTransactionHandle transaction) throws
IOException, InterruptedException;
Review Comment:
to return the prepared transaction state, and stored that value in
KafkaShareAckTransactionManager snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
