jubins commented on PR #28332: URL: https://github.com/apache/flink/pull/28332#issuecomment-4827262990
@snuyanzin you're right that the tests passed without the fix, the original catch (Throwable ignored) was silently swallowing the `NullPointerException` from `connectedSocket.close()`. I've fixed this PR with two improvements: the `null` check itself, and replacing the overly broad `catch (Throwable)` with the precise catch `(IOException)`. Let me know if anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
