snuyanzin commented on code in PR #28510:
URL: https://github.com/apache/flink/pull/28510#discussion_r3510794061
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala:
##########
@@ -558,6 +595,28 @@ abstract class PlannerBase(
tableSink);
}
+ private def convertMaterializedTableToRel(
+ identifier: ObjectIdentifier,
+ resolvedTable: ResolvedCatalogTable,
+ queryOperation: QueryOperation,
+ staticPartitions: Map[String, String]): RelNode = {
+ val input = createRelBuilder.queryOperation(queryOperation).build()
+ val catalog = toScala(catalogManager.getCatalog(identifier.getCatalogName))
+
+ val tableSink =
+ createDynamicTableSink(identifier, catalog, resolvedTable, isTemporary =
false)
+
+ DynamicSinkUtils.convertMaterializedTableAsToRel(
+ createRelBuilder,
+ input,
+ catalog.orNull,
+ identifier,
+ resolvedTable,
+ JavaScalaConversionUtil.toJava(staticPartitions),
Review Comment:
looks like this parameter is always created during method call
then why do we need to create in scala and then translate to java rather
than create in Java in first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
