twalthr commented on code in PR #28595:
URL: https://github.com/apache/flink/pull/28595#discussion_r3518440605
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala:
##########
@@ -340,6 +341,63 @@ class TableSinkITCase(mode: StateBackendMode) extends
StreamingWithStateTestBase
"Table options do not contain an option key 'connector' for
discovering a connector.")
}
+ @TestTemplate
+ def testCreateTableAsSelectOverSetSemanticPtf(): Unit = {
Review Comment:
Please reduce the number of tests. What is the difference between
TableSinkITCase and RTASITCase? Same for TableSinkTest vs.
SqlRTASNodeToOperationConverterTest. Each test needs a purpose. If you add an
ITCase anyway, you automatically test the layers underneath. Unless you are
looking for something very particular in the lower layers.
##########
flink-table/flink-table-planner/src/test/resources/explain/testExplainCtasWithColumnsInCreateAndQueryParts.out:
##########
@@ -1,14 +1,14 @@
== Abstract Syntax Tree ==
-LogicalSink(table=[default_catalog.default_database.MyCtasTable],
fields=[EXPR$0, a, b])
-+- LogicalProject(EXPR$0=[null:INTEGER], a=[$0], b=[$1])
+LogicalSink(table=[default_catalog.default_database.MyCtasTable],
fields=[votes, a, b, metadata_col])
Review Comment:
Isn't this a breaking change? The EXPR$0 to votes makes sense, but the
additional metadata_col?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
