raminqaf commented on code in PR #28595:
URL: https://github.com/apache/flink/pull/28595#discussion_r3518764860
##########
flink-table/flink-table-planner/src/test/resources/explain/testExplainCtasWithColumnsInCreateAndQueryParts.out:
##########
@@ -1,14 +1,14 @@
== Abstract Syntax Tree ==
-LogicalSink(table=[default_catalog.default_database.MyCtasTable],
fields=[EXPR$0, a, b])
-+- LogicalProject(EXPR$0=[null:INTEGER], a=[$0], b=[$1])
+LogicalSink(table=[default_catalog.default_database.MyCtasTable],
fields=[votes, a, b, metadata_col])
Review Comment:
Not a breaking change. `metadata_col` appears only because I extended this
test's DDL to also declare a persisted metadata column and a virtual one, to
add CTAS coverage for those column kinds. It's a change to the test input, not
to planner behavior.
I verified on master: running this exact DDL there already produces the same
plan, including `metadata_col`:
```
LogicalSink(table=[…MyCtasTable], fields=[votes, a, b, metadata_col])
+- LogicalProject(votes=[null:INTEGER], a=[$0], b=[$1],
metadata_col=[null:BIGINT])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
