raminqaf commented on code in PR #28510:
URL: https://github.com/apache/flink/pull/28510#discussion_r3519878309
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/materializedtable/AlterMaterializedTableAsQueryOperation.java:
##########
@@ -40,8 +41,9 @@ public class AlterMaterializedTableAsQueryOperation extends
AlterMaterializedTab
public AlterMaterializedTableAsQueryOperation(
ObjectIdentifier tableIdentifier,
Function<ResolvedCatalogMaterializedTable, List<TableChange>>
tableChangesForTable,
- ResolvedCatalogMaterializedTable oldTable) {
- super(tableIdentifier, tableChangesForTable, oldTable);
+ ResolvedCatalogMaterializedTable oldTable,
+ QueryOperation sinkModifyQuery) {
Review Comment:
I am a bit confused about the suggestion. Should I just re-write the name of
the parameter to contain `Operation` or change also the type to
`ModifyOperation`. Because the latter can not be applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
