aka-dag commented on code in PR #867:
URL: https://github.com/apache/flink-agents/pull/867#discussion_r3529526277
##########
python/flink_agents/plan/tests/compatibility/create_python_option_from_java_option.py:
##########
@@ -15,36 +15,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#################################################################################
-from pathlib import Path
-
-from pyflink.util.java_utils import add_jars_to_context_class_loader
-
from flink_agents.api.core_options import (
AgentConfigOptions,
AgentExecutionOptions,
+ EventLogLevel,
ShortTermMemoryTtlUpdate,
ShortTermMemoryTtlVisibility,
)
-# This script is used to verify that Java-defined configuration options
-# (e.g., AgentConfigOptions) are correctly exposed and accessible in the
-# Python environment via the JAR file. It loads a Java JAR into the Python
-# context and performs basic assertions on the configuration keys, types,
-# and default values to ensure compatibility between Java and Python layers.
-#
-# The JAR file path is relative to this script and should be updated if
-# the build structure changes.
+# This script verifies that Python configuration options stay aligned with the
Review Comment:
Thanks for the detailed review — agreed on both points.
**Regression test:** Added
`python/flink_agents/api/tests/test_core_options.py` to lock in the Pemja
import fix:
- AST check: `core_options.py` does not `import pyflink`
- Import tests: `flink_agents.api.core_options` and
`flink_agents.runtime.flink_runner_context` do not call `get_gateway()`
- Sanity checks: all 23 options are explicitly declared; unknown attributes
raise `AttributeError`
**Java/Python parity:** Restored JAR-based cross-check in
`create_python_option_from_java_option.py` with shared helpers in
`java_python_config_option_parity.py` (key / type / default for each option).
This script still runs via `test_java_config_in_python.sh` as a standalone
client-side process — using `get_gateway()` here is intentional and separate
from the runtime import path we are fixing. The comment now clarifies this is a
client-side parity script, not the Pemja runtime path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
