aka-dag commented on PR #867: URL: https://github.com/apache/flink-agents/pull/867#issuecomment-4893822672
> Hi @aka-dag, the approach looks good to me. I have one follow-up before merging: please add the Java/Python parity check in CI to ensure that the two AgentConfigOptions definitions do not drift silently. Hi @GreatEugenius, thanks for the review. I've restored the JAR-based Java/Python parity check in `create_python_option_from_java_option.py`. It compares every Python ConfigOption (key, type, default) against the Java `AgentConfigOptions` / `AgentExecutionOptions` definitions. This script is already invoked in CI via `e2e-test/test-scripts/test_java_config_in_python.sh` (called from `tools/e2e.sh` in the e2e workflow). With the JAR loading restored, a Java-side change that Python doesn't mirror will fail that step instead of drifting silently. The runtime regression guard (`test_core_options.py`) runs in the regular Python unit test suite (`./tools/ut.sh -p`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
