bharathgunapati commented on PR #52: URL: https://github.com/apache/flink-connector-http/pull/52#issuecomment-4915772190
Thanks for the review, @davidradl! Addressed the nits: **Sink asymmetry** — added an inline comment in AbstractRequestSubmitter explaining the sink still reads from Properties today; full ReadableConfig wiring is planned as a follow-up PR. **testLookupJoinWithUrlAsJoinKey_DISABLED** — noted that '30s' is a dormant fixture update (@Test is commented out); active coverage is testHttpLookupJoinWithDurationRequestTimeout. **requestTimeoutDefaultsToThirtySeconds** — added a clarifying comment that empty Configuration exercises the option-default path. **requestTimeoutOptionTest** — switched to catchThrowable with a null-safe check so the assertion always runs (including when INSERT succeeds). **httpRequestTimeout** in tests — same-package access to protected is intentional; no getter added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
