bharathgunapati commented on code in PR #52:
URL:
https://github.com/apache/flink-connector-http/pull/52#discussion_r3559095220
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/RequestFactoryBase.java:
##########
@@ -44,14 +44,12 @@
@Slf4j
public abstract class RequestFactoryBase implements HttpRequestFactory {
- public static final String DEFAULT_REQUEST_TIMEOUT_SECONDS = "30";
Review Comment:
Updated requestTimeoutOptionTest to use explicit null-check +
isNotInstanceOf(ValidationException) — only asserts when INSERT throws, which
matches the test intent (runtime failures are acceptable, ValidationException
is not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
