p-eye commented on PR #28498:
URL: https://github.com/apache/flink/pull/28498#issuecomment-4932571378
Thanks for the detailed review! I've addressed all the remaining points
regarding bugs and test gaps in the latest squashed commit:
- **Dynamic Indexing**: Replaced the hardcoded index with a dynamic lookup
(`indexOf("source")`) to safely handle partial metadata selections. I also
added a dedicated test case
(`testDeserializationWithMetadata_SourceDatabaseOnly`) to verify requests
without `ingestion-timestamp`.
- **Lifecycle Bug & Test Gap**: Refactored the test constructor to inject
`SchemaCoderProvider` instead of a pre-built deserializer. This ensures the
test drives the true production `open()` path, and the underlying null-schema
NPE has been fully resolved and covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
