prashantbh commented on code in PR #28201:
URL: https://github.com/apache/flink/pull/28201#discussion_r3556954325
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java:
##########
@@ -241,29 +254,83 @@ public boolean isInitialized() {
@Override
public void grantLeadership(UUID leaderSessionID) {
- runIfStateRunning(
- () -> startJobMasterServiceProcessAsync(leaderSessionID),
- "starting a new JobMasterServiceProcess");
+ synchronized (lock) {
+ if (!isRunning()) {
+ LOG.debug(
+ "Ignore 'starting a new JobMasterServiceProcess'
because the leadership runner is no longer running.");
+ return;
+ }
+ sequentialOperation =
+ sequentialOperation.thenCompose(
+ unused ->
flushPendingOrStartNewProcessAsync(leaderSessionID));
+ handleAsyncOperationError(sequentialOperation, "Could not start
the job manager.");
+ }
+ }
+
+ private CompletableFuture<Void> flushPendingOrStartNewProcessAsync(UUID
leaderSessionId) {
Review Comment:
Done. Keeping `handleCachedGloballyTerminalJobOrStartNewProcessAsync `,
assuming extra "d" is a typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
