prashantbh commented on code in PR #28201:
URL: https://github.com/apache/flink/pull/28201#discussion_r3557008538
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/DefaultJobMasterServiceProcessTest.java:
##########
@@ -268,6 +268,34 @@ void testSuccessOnTerminalState() {
== JobStatus.FINISHED);
}
+ @Test
Review Comment:
Added `testGloballyTerminalResultFromStaleProcessIsNotCached` for exactly
that, drives two leadership terms and checks the stale process's terminal
result doesn't get cached (close ends up SUSPENDED, not FAILED). I have put it
in `JobMasterServiceLeadershipRunnerTest` since the else branch lives in the
runner rather than `DefaultJobMasterServiceProcessTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
