[
https://issues.apache.org/jira/browse/FLINK-40127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-40127:
-----------------------------------
Labels: pull-request-available (was: )
> JDBC connector: 37 files ship without the required ASF license header
> ---------------------------------------------------------------------
>
> Key: FLINK-40127
> URL: https://issues.apache.org/jira/browse/FLINK-40127
> Project: Flink
> Issue Type: Bug
> Components: Connectors / JDBC
> Reporter: Purushottam Sinha
> Priority: Minor
> Labels: pull-request-available
>
> Problem
>
>
> 37 files across flink-connector-jdbc are missing the ASF license header
> required on every source file, despite apache-rat-plugin being configured in
> the build. None are new — every flagged file traces back to 2024, predating
> v4.0.0's actual release.
>
>
>
>
>
> Evidence
>
>
> - Per-module org.apache.rat:apache-rat-plugin:check on current main (not
> just grepping) finds headers missing in 27 Java files under
> flink-connector-jdbc-core (XA transaction classes, JdbcCatalog,
> FilterHandlingPolicy, JdbcCommitter/JdbcCommitable, and their tests),
> flink-connector-jdbc-db2's pom.xml and Db2Images.java, and pom.xml in 7 other
> vendor modules plus flink-connector-jdbc-architecture.
> - Root cause of why it went uncaught: the root pom's apache-rat-plugin
> declares <inherited>false</inherited>, which stops its excludes config from
> cascading to submodules, and its verify-bound execution never actually fires
> in CI (confirmed against a live run, 29036257102) — tracked separately, not
> part of this fix.
>
> - Same pattern (and real header gaps) also found in flink-connector-pulsar
> and flink-connector-hbase; out of scope here.
>
>
>
>
> Proposed fix
>
>
> - Add the standard ASF license header to all 37 flagged files, matching the
> sibling files in the same modules.
>
>
>
>
> Acceptance
>
>
> - Each affected module passes org.apache.rat:apache-rat-plugin:check for
> the files touched.
>
> - core and db2 still compile.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
