jigar-bhati commented on code in PR #267:
URL:
https://github.com/apache/flink-connector-kafka/pull/267#discussion_r3626597627
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/DynamicKafkaSourceBuilder.java:
##########
@@ -257,7 +257,7 @@ private void setRequiredConsumerProperties() {
maybeOverride(
ConsumerConfig.AUTO_OFFSET_RESET_CONFIG,
startingOffsetsInitializer.getAutoOffsetResetStrategy().name().toLowerCase(),
- true);
+ false);
Review Comment:
Correct. I removed the eager dynamic-builder default, so property presence
again means it was explicitly configured. The reader/enumerator derive the
fallback only after cluster metadata is known; I also added coverage for
global, cluster, and initializer precedence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
