jigar-bhati commented on code in PR #267:
URL:
https://github.com/apache/flink-connector-kafka/pull/267#discussion_r3684945213
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaPropertiesUtil.java:
##########
@@ -36,6 +39,25 @@ public static void copyProperties(@Nonnull Properties from,
@Nonnull Properties
}
}
+ /** Resolves an explicit global or cluster reset strategy before the
initializer default. */
Review Comment:
Yes, that precedence was inconsistent with the rest of the dynamic source. I
changed it to explicit cluster property > explicit global property > effective
initializer strategy. An explicit global value still wins over a cluster
initializer, because the initializer remains only the fallback when neither
property is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
