weiqingy commented on PR #28827: URL: https://github.com/apache/flink/pull/28827#issuecomment-5160607994
Hi @RocMarshal, #28796 is merged, so this one is rebased onto master and out of draft. The diff is now standalone: 5 files, +80, adding the optional `target` option to the `EARLY_FIRE` hint. One thing worth your eye: the rule-level target check in `StreamPhysicalIntervalJoinRule` is unreachable from SQL today, since the hint checker already rejects any value other than `interval_join`. I kept it because it is the piece that makes a hint aimed at a future operator kind get ignored by the interval join rather than misapplied, which is the forward-compatibility contract from the FLIP. Happy to drop it if you would rather not carry unreachable code. PTAL when you have a moment. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
