RocMarshal commented on code in PR #28827:
URL: https://github.com/apache/flink/pull/28827#discussion_r3736561355
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalIntervalJoinRule.java:
##########
@@ -170,6 +170,12 @@ private static EarlyFire extractEarlyFire(List<RelHint>
hints, boolean isEventTi
}
Configuration conf = Configuration.fromMap(earlyFireHint.kvOptions);
+ // target scopes the hint to one operator kind: this rule applies it
only when it targets
+ // the interval join, and leaves a hint aimed at any other operator
kind untouched.
+ String target = conf.get(EarlyFireJoinHintOptions.TARGET);
+ if (target != null &&
!EarlyFireJoinHintOptions.INTERVAL_JOIN.equals(target)) {
Review Comment:
Sorry and thanks @weiqingy for your clarify.
Given that this involves changing a config default, I'm unsure if it
conflicts with the ratified FLIP.
That said, the original implementation remains perfectly reasonable to me.
If altering this default goes against the design outlined in the FLIP, please
revert to the original approach. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
