wenjin272 commented on code in PR #933:
URL: https://github.com/apache/flink-agents/pull/933#discussion_r3711221546


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -25,3 +25,12 @@ Linked issue: #xxx
 - [ ] `doc-needed` <!-- Your PR changes impact docs -->
 - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
 - [ ] `doc-included` <!-- Your PR already contains the necessary documentation 
updates -->
+
+### Was this patch authored or co-authored using generative AI tooling?
+
+<!-- Do not remove this section. Check the proper box only. -->
+
+- [ ] Yes
+- [ ] No
+
+If yes, include a `Generated-by: <tool name and version>` line in this 
description. See the [ASF generative tooling 
guidance](https://www.apache.org/legal/generative-tooling.html).

Review Comment:
   The ASF guidance recommends putting `Generated-by:` in the source-control 
commit message so it can support future machine-readable provenance. However, 
this repository currently uses `squashMergeCommitMessage=COMMIT_MESSAGES` and 
also allows rebase merges, so a line present only in the PR description is not 
preserved in Git history by default; this PR itself has the line in its body 
while commit `406c1d7d` has an empty message body. Could we require the trailer 
in the commit message as well, while keeping the PR-body disclosure for 
reviewer visibility, or otherwise adjust the merge configuration/policy to 
guarantee it survives?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to