weiqingy commented on code in PR #933: URL: https://github.com/apache/flink-agents/pull/933#discussion_r3718303388
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -25,3 +25,12 @@ Linked issue: #xxx - [ ] `doc-needed` <!-- Your PR changes impact docs --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-included` <!-- Your PR already contains the necessary documentation updates --> + +### Was this patch authored or co-authored using generative AI tooling? + +<!-- Do not remove this section. Check the proper box only. --> + +- [ ] Yes +- [ ] No + +If yes, include a `Generated-by: <tool name and version>` line in this description. See the [ASF generative tooling guidance](https://www.apache.org/legal/generative-tooling.html). Review Comment: You're right, I had the reasoning backwards in the PR description. I checked what actually survives. Squash composes the merged body from the source commit messages, so `bc55d97e` (#957) has an empty body despite a long PR description, while `55ccb13e` (#904) kept the prose from its commit. Rebase drops the body entirely. On both enabled paths the commit message survives and the description does not. Took your first option rather than touching the merge configuration, since switching squash to `PR_BODY` would still leave the rebase path unfixed. Updated in 108353ef: the template and the `AGENTS.md` sentence now ask for the line in the commit message, keeping the description copy for reviewer visibility. That commit carries the trailer itself, and I've corrected the claim in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
