SEPURI-SAI-KRISHNA commented on code in PR #28931:
URL: https://github.com/apache/flink/pull/28931#discussion_r3729690331
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/StringFunctionsITCase.java:
##########
@@ -182,6 +182,22 @@ private Stream<TestSetSpec> eltTestCases() {
DataTypes.VARCHAR(5))
.testResult(
lit(2).elt("a", "b"), "ELT(2, 'a', 'b')", "b",
DataTypes.CHAR(1))
+ // FLINK-40338: non-INT INTEGER_NUMERIC index must not
throw ClassCastException
+ .testResult(
+ lit(2).cast(DataTypes.TINYINT()).elt("scala",
"java"),
+ "ELT(CAST(2 AS TINYINT), 'scala', 'java')",
+ "java",
+ DataTypes.VARCHAR(5))
+ .testResult(
+ lit(2).cast(DataTypes.SMALLINT()).elt("scala",
"java"),
+ "ELT(CAST(2 AS SMALLINT), 'scala', 'java')",
+ "java",
+ DataTypes.VARCHAR(5))
+ .testResult(
+ lit(2).cast(DataTypes.BIGINT()).elt("scala",
"java"),
+ "ELT(CAST(2 AS BIGINT), 'scala', 'java')",
+ "java",
+ DataTypes.VARCHAR(5))
Review Comment:
@raminqaf agreed. Here's the patch I have locally, already verified, it
fails with `ClassCastException` on `java.lang.Byte`, `Short` and `Long` before
the fix and passes after:
```java
.onFieldsWithData(null, null, null, new byte[] {1, 2, 3}, (byte) 2, (short)
2, 2L)
.andDataTypes(
DataTypes.INT(), DataTypes.STRING(), DataTypes.BYTES(),
DataTypes.BYTES(),
DataTypes.TINYINT(), DataTypes.SMALLINT(), DataTypes.BIGINT())
```
```java
.testResult(
$("f4").elt("scala", "java"),
"ELT(f4, 'scala', 'java')",
"java",
DataTypes.VARCHAR(5))
.testResult(
$("f5").elt("scala", "java"),
"ELT(f5, 'scala', 'java')",
"java",
DataTypes.VARCHAR(5))
.testResult(
$("f6").elt("scala", "java"),
"ELT(f6, 'scala', 'java')",
"java",
DataTypes.VARCHAR(5))
```
@hulincup feel free to take these directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
