SEPURI-SAI-KRISHNA commented on PR #28931:
URL: https://github.com/apache/flink/pull/28931#issuecomment-5211163876
Thanks @hulincup, appreciated — and no hard feelings, it's an easy thing to
miss.
One build heads-up: the new onFieldsWithData line is 106 chars, over the
100-column AOSP limit that spotless enforces (google-java-format 1.24.0,
pom.xml). mvn spotless:apply will wrap it to:
.onFieldsWithData(
null, null, null, new byte[] {1, 2, 3}, (byte) 2, (short) 2, 2L)
Worth running before the next push — CI is red on the earlier commit.
Minor: since the test code was taken as-is, a Co-authored-by: trailer on
8ee7dd53 would be the conventional attribution. Entirely up to you — the
mention in the message is already generous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
