spuru9 commented on code in PR #28962:
URL: https://github.com/apache/flink/pull/28962#discussion_r3836763549
##########
pom.xml:
##########
@@ -1824,6 +1824,14 @@ under the License.
<includes>
<include>${test.unit.pattern}</include>
</includes>
+ <excludes>
+ <!-- Overrides
surefire's default excludes, which drop **/*$* and
+ thereby
hide every nested test class. The include pattern above
+ is
name-based, so only nested classes ending in Test/Tests are
+ picked up.
Keep this list non-empty; an empty list restores the
+ defaults.
-->
Review Comment:
Would remove it before merge. Was just testing first if this actually works.
Waiting on your opinion on
https://github.com/apache/flink/pull/28962#issuecomment-5285918346
With this settings we will have duplicate run for many tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
