snuyanzin commented on code in PR #28962:
URL: https://github.com/apache/flink/pull/28962#discussion_r3843238104
##########
pom.xml:
##########
@@ -1824,6 +1824,14 @@ under the License.
<includes>
<include>${test.unit.pattern}</include>
</includes>
+ <excludes>
+ <!-- Overrides
surefire's default excludes, which drop **/*$* and
+ thereby
hide every nested test class. The include pattern above
+ is
name-based, so only nested classes ending in Test/Tests are
+ picked up.
Keep this list non-empty; an empty list restores the
+ defaults.
-->
Review Comment:
yes, probably better fix tests then
however in that case we need ArchUnit rule to make all new tests written in
same way failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
