dalelane commented on code in PR #293:
URL:
https://github.com/apache/flink-connector-kafka/pull/293#discussion_r3883344162
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java:
##########
@@ -76,6 +76,12 @@ public class KafkaPartitionSplitReader
// Tracking empty splits that has not been added to finished splits in
fetch()
private final Set<String> emptySplits = new HashSet<>();
+ // Offset of the last record that fetch() handed to the source reader, per
partition
+ private final Map<TopicPartition, Long> lastFetchedOffsets = new
HashMap<>();
+
+ // Consumer position observed at the end of the most recent fetch(), per
partition.
+ private final Map<TopicPartition, Long> lastKnownPositions = new
HashMap<>();
Review Comment:
That's a good point, sorry - added cleanup in
7e962f7ea1d4297206453d35c6a9f93ac5d1a6e4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
