raoraoxiong commented on code in PR #28998:
URL: https://github.com/apache/flink/pull/28998#discussion_r3920905730
##########
flink-python/pyflink/table/tests/test_udf.py:
##########
@@ -926,6 +926,135 @@ def test_create_and_drop_function(self):
self.assertTrue('add_one_func' not in
t_env.list_user_defined_functions())
self.assertTrue('subtract_one_func' not in
t_env.list_user_defined_functions())
+ def test_python_local_ref_reuse(self):
Review Comment:
removed the top-level and condition
cases. Your point about the cost across three execution modes is fair, and
those
paths are already covered by the rules from #28638 and by
`PythonCalcConditionCseTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]