raminqaf commented on code in PR #29073:
URL: https://github.com/apache/flink/pull/29073#discussion_r3924825849
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java:
##########
@@ -167,27 +168,83 @@ class CastRulesTest {
/** U+1D54F, one code point but two UTF-16 units and four UTF-8 bytes. */
private static final String NON_BMP = "𝕏";
+ private static final VariantBuilder VARIANT_BUILDER = Variant.newBuilder();
private static final Variant VARIANT_ARRAY =
- Variant.newBuilder()
+ VARIANT_BUILDER
.array()
- .add(Variant.newBuilder().of(1))
- .add(Variant.newBuilder().of("two"))
- .add(Variant.newBuilder().of(false))
- .add(Variant.newBuilder().ofNull())
+ .add(VARIANT_BUILDER.of(1))
+ .add(VARIANT_BUILDER.of("two"))
+ .add(VARIANT_BUILDER.of(false))
+ .add(VARIANT_BUILDER.ofNull())
.build();
private static final Variant VARIANT_OBJECT =
- Variant.newBuilder()
+ VARIANT_BUILDER
.object()
.add(
"k",
- Variant.newBuilder()
+ VARIANT_BUILDER
.array()
- .add(Variant.newBuilder().of(1))
- .add(Variant.newBuilder().of(2))
+ .add(VARIANT_BUILDER.of(1))
+ .add(VARIANT_BUILDER.of(2))
.build())
.build();
+ /** {@code [1, 2, 3]}, the design's running array value. */
+ private static final Variant VARIANT_INT_ARRAY =
+ VARIANT_BUILDER
+ .array()
+ .add(VARIANT_BUILDER.of(1))
+ .add(VARIANT_BUILDER.of(2))
+ .add(VARIANT_BUILDER.of(3))
+ .build();
+
+ /** {@code [1, null, 3]}, an array carrying a JSON null element. */
Review Comment:
https://github.com/apache/flink/pull/29073#discussion_r3924823272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
