Alwaysgaurav1 commented on PR #28943:
URL: https://github.com/apache/flink/pull/28943#issuecomment-5550658307
Hey @spuru9, taking a look at this PR:
1. **Redundant JNI Native Library Reloading in `@BeforeEach`**:
In test classes like `RocksDBMemoryControllerUtilsTest`, you have
configured `@BeforeEach void ensureRocksDbNativeLibraryLoaded(@TempDir Path
temporaryFolder)` which needlessly unpacks and attempts JNI loading into
separate temp directories on **every single test execution** instead of
utilizing a static `@BeforeAll` with a class-level `@TempDir static Path`. This
introduces unnecessary I/O overhead on CI.
2. **Monolithic PR Scope**:
Migrating 21 test files across the entire module in a single automated
bulk commit (`Claude Code`) creates a large review surface for maintainers.
Smaller, verified PRs segmented by component (e.g. state memory controller vs
incremental checkpoint recovery) are typically preferred for fast review and
bisectability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
