spuru9 commented on PR #28943: URL: https://github.com/apache/flink/pull/28943#issuecomment-5550807423
Thanks for the comment On the native lib — it doesn't re-unpack per test. NativeLibraryLoader has a static initialized guard, so it unpacks once per JVM; the later `@BeforeEach` calls just hit a no-op. I kept it per-test to match the original `@Before` and the already-merged ForSt sibling ForStMemoryControllerUtilsTest (files that were `@BeforeClass` did become static `@BeforeAll`). If you want to drill down on that, a JIRA for that for both the ForSt and RocksDB looks more appropriate. On scope — it's intentionally one module per JIRA, same as how ForSt was done. All mechanical, counts unchanged, CI green. It is as per the convention we have been following under the umbrella JIRA https://issues.apache.org/jira/browse/FLINK-25325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
