raminqaf commented on code in PR #29128:
URL: https://github.com/apache/flink/pull/29128#discussion_r3956792349


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/UuidTestPrograms.java:
##########
@@ -112,4 +189,101 @@ private static SourceTestStep singleRowDriver() {
                             ValidationException.class,
                             "Invalid UUID string: abcd")
                     .build();
+
+    private static SourceTestStep groupingSource() {
+        return SourceTestStep.newBuilder("t")
+                .addSchema("id UUID")
+                .producedValues(
+                        Row.of(UUID_ZERO),
+                        Row.of(UUID_ZERO),
+                        Row.of(UUID_A),
+                        Row.of(UUID_MAX),
+                        Row.of(UUID_MAX),
+                        Row.of(UUID_MAX))
+                .build();
+    }
+
+    // The row number encodes the sort position, so a set comparison still 
pins down the order:
+    // ZERO < UUID_A (0x55) < HIGH_BIT (0x80) < MAX (0xff) holds only under 
the unsigned ordering.
+    static final TableTestProgram UUID_ORDER_BY =

Review Comment:
   Moved the program up. Also renamed `UuidBatchSemanticTest` -> 
`UuidSemanticTest` and moved it under nodes.exec.batch
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to