twalthr commented on code in PR #29128:
URL: https://github.com/apache/flink/pull/29128#discussion_r3968759438
##########
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BitmapSerializer.java:
##########
@@ -60,7 +61,7 @@ public int getLength() {
@Override
public void serialize(Bitmap record, DataOutputView target) throws
IOException {
- byte[] bytes = record.toBytes();
+ byte[] bytes = RoaringBitmapData.toRoaringBitmapData(record).toBytes();
Review Comment:
Let's drop this change, not really necessary. There should be no other
Bitmap implementation.
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/extraction/TypeInferenceExtractorTest.java:
##########
@@ -1491,8 +1481,10 @@ public String toString() {
//
--------------------------------------------------------------------------------------------
@FunctionHint(
- input = {@DataTypeHint("INT"), @DataTypeHint("STRING")},
- argumentNames = {"i", "s"},
+ arguments = {
Review Comment:
please undo these changes, they test deprecated API. Always double check all
changes one more time before asking for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
