slachiewicz commented on PR #314: URL: https://github.com/apache/flink-connector-kafka/pull/314#issuecomment-5623764386
Thanks. All three taken, with two of them turning out differently because of the rewrite in eb13af06, which I think crossed with your comment: 1. Downscale: agreed, and it is the strongest case. Description and release note now lead with it, and `testAbortsSupersededPrecommittedTransactionOfSecondaryOwnedSubtask` covers it: `ownsTransactionalId` includes the secondary owned subtask ids and their precommitted transactions come from the same restored states, so the recovery aborts them. 2. Live owner: the committer no longer bumps at all. The abort runs in `LISTING` at recovery, before the new attempt holds any id, on a precommitted id whose broker epoch is newer than the snapshotted one or whose producer id differs. The only possible holders at that point are the failed attempt and a zombie, and fencing a zombie from the newest attempt is the intended direction, so no start-time comparison is needed. `describeTransactions` is what decides it, in `AdminUtils` and `TransactionAbortStrategyContextImpl`. 3. FLINK-39218: this version adds no epoch-bump helper; the abort goes through the existing `TransactionAborter`, the same pool-and-`initTransactions` path `LISTING` already uses for non-precommitted ids. `AdminUtils.describeTransactions` is reusable by #296 if the tool wants producer id, epoch and state per id. Happy to have @Savonitar review. Local runs on eb13af06: the module unit suite (441), and every ITCase in the sink package against a Kafka container (`KafkaSinkITCase` 59, `ExactlyOnceKafkaWriterITCase` 14, `KafkaWriterITCase` 12, `FlinkKafkaInternalProducerITCase` 9, `ProducerPoolImplITCase` 8, `KafkaWriterFaultToleranceITCase` 4, `KafkaTransactionLogITCase` 1), all green. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
