spoorthibasu commented on PR #4418: URL: https://github.com/apache/flink-cdc/pull/4418#issuecomment-5681623967
Both comments are addressed inline. Two related changes in the same area: - The coordinator's record of which subtask holds the binlog split (used by the reset detection) is now only set from `BinlogSplitAssignedEvent` when it is unknown, and ignores an event naming a different subtask, so a stale event from a failed attempt can't point it at the wrong reader. Test: `testStaleBinlogSplitAssignedEventDoesNotCorruptHolder`. - The released flag is now persisted in the checkpoint (serializer v6, older checkpoints default to not-released) rather than reconstructed on restore from the other state fields, which matches how the serializer already versions its other fields. Happy to keep it reconstructed if you'd rather avoid the version bump. Docs (EN and ZH) and the PR description are updated. The Chinese is a best-effort translation of the English, so please feel free to correct the wording. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
