spoorthibasu commented on code in PR #4418:
URL: https://github.com/apache/flink-cdc/pull/4418#discussion_r4022615061
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/assigners/state/PendingSplitsStateSerializer.java:
##########
@@ -45,8 +45,7 @@
*/
public class PendingSplitsStateSerializer implements
SimpleVersionedSerializer<PendingSplitsState> {
- // TODO: need proper implementation of the new version
- private static final int VERSION = 5;
+ private static final int VERSION = 6;
Review Comment:
The serializer now writes v6 only when the option is enabled, so a
default-off job keeps writing v5 and stays restorable by an older build.
Restoring a released state with the option off fails fast instead of dropping
the marker. Tests: `testReleaseDisabledJobKeepsWritingV5Format` and
`testFailFastWhenReleaseDisabledOnReleasedRestore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
