MartijnVisser opened a new pull request, #29227:
URL: https://github.com/apache/flink/pull/29227
## What is the purpose of the change
The shade relocations in both flink-model poms name Maven groupIds,
`com.squareup` and
`org.apache.httpcomponents`, not Java packages. They never match, so jackson
is the only thing
relocated and both jars publish the rest in the default namespace: 1405
unrelocated classes in
flink-model-triton, 13250 in flink-model-openai.
## Brief change log
- Relocations name the real packages, with a trailing dot, since shade
matches a pattern as a
bare prefix against string constants too
- No `org.apache.hc`: openai-java 4.63.1 no longer pulls httpclient5.
`io.swagger`,
`com.github.victools` and `com.fasterxml:classmate` are added, because
it now pulls those
- The target gains a `shaded` segment, which is what stops ArchUnit
importing relocated
classes as production code. It imports 1336 of them today
- `com.openai` and `kotlin` stay unrelocated in flink-model-openai; the
pom records why
- flink-model-triton pins Kotlin to 1.9.10, the version okio-jvm 3.6.0 is
built against, and
no longer bundles empty or metadata-only Kotlin artifacts
- `check_shaded_artifacts_model` fails the build on any unrelocated
dependency
## Verifying this change
Nothing in the build inspected these jars. The new check is red on both
modules before this
change and green after.
The relocation set was measured by running each module's tests against the
shaded jar instead of
`target/classes`. flink-model-openai is 22/22 on master and as proposed, but
10/22 with
`com.openai` relocated, and relocating `kotlin` breaks kotlin-reflect once
no other
kotlin-stdlib is on the classpath. flink-model-triton bundles no
kotlin-reflect and relocates
Kotlin safely.
Both NOTICE files now match the shade log exactly. Aggregate javadoc,
flink-docs and
flink-architecture-tests-production were run as well.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no, but four
artifacts that contribute
no classes are no longer bundled and flink-model-triton's Kotlin is
pinned to 1.9.10
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no. Relocated
types do appear in public signatures of the shaded jars, as jackson
already does
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
