snuyanzin commented on code in PR #29227:
URL: https://github.com/apache/flink/pull/29227#discussion_r4056658390


##########
flink-models/flink-model-triton/pom.xml:
##########
@@ -34,9 +34,32 @@ under the License.
 
        <properties>
                <okhttp.version>4.12.0</okhttp.version>
+               <!-- okhttp 4.12.0 asks for 1.8.21 but okio-jvm 3.6.0, which it 
pulls in, is built
+                    against 1.9.10. Pin both to 1.9.10 so one Kotlin runtime 
is bundled. -->

Review Comment:
   can we avoid sticking to versions in comments, we already have versions in 
properties which should be enough.
   Versions in comments are often becoming stale



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to