dianfu commented on code in PR #29210:
URL: https://github.com/apache/flink/pull/29210#discussion_r4043651939
##########
flink-python/pyflink/table/udf.py:
##########
@@ -760,10 +762,19 @@ def _get_python_env():
def _create_udf(f, input_types, result_type, func_type, deterministic, name):
+ if func_type == 'arrow':
Review Comment:
I guess we can also apply this validation for pandas UDF?
##########
flink-python/src/main/java/org/apache/flink/table/runtime/arrow/writers/MapWriter.java:
##########
@@ -84,6 +84,13 @@ public void doWrite(T in, int ordinal) {
}
}
+ @Override
+ public void reset() {
Review Comment:
What's the purpose of this change? Does it apply for existing Pandas UDF? If
so, I guess we need split it into a separate PR to make it possible to backport
to existing releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
