auroflow commented on code in PR #29210:
URL: https://github.com/apache/flink/pull/29210#discussion_r4043947251


##########
flink-python/src/main/java/org/apache/flink/table/runtime/arrow/writers/MapWriter.java:
##########
@@ -84,6 +84,13 @@ public void doWrite(T in, int ordinal) {
         }
     }
 
+    @Override
+    public void reset() {

Review Comment:
   Yes, this fixes an existing bug affecting pandas UDFs too. Between Arrow 
batches, the map vector resets, but its key/value writers retain their 
counters. Subsequent batches then write children at incorrect positions.
   
   I have taken this fix out of this PR and created 
[LINK-40705](https://issues.apache.org/jira/browse/FLINK-40705) to address this 
separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to