[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848055#comment-15848055
]
ASF GitHub Bot commented on FLINK-2168:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3149
The points I raised effect the API and different people tend to have
different opinions about APIs ;-).
I suggested to use a flat schema with that names columns
`columnFamily$qualifier`, i.e., no nesting but composing the column name from
`colFamily` and `qualifier` and separating them by `$`. Internally we can and
should still use the `family`-`qualifier` but just map everything to a flat
schema. The question is whether this would that make the `HBaseTableSource`
harder to use. I don't think the column access (`family.qualifier` vs.
`family$qualifier`) would be much harder, but acting with families that have
lots of columns would be more cumbersome, because each column would be a
top-level column and would need to be explicitly selected in a `SELECT` clause.
In the nested case, all columns of a family are conveniently grouped together.
Regarding the `HBaseTableSchema`, we could also use it only internally and
not expose it to the user. The `HBaseTableSource` would have a method
`addColumn()` and forward the calls to its internal `HBaseSchema`.
> Add HBaseTableSource
> --------------------
>
> Key: FLINK-2168
> URL: https://issues.apache.org/jira/browse/FLINK-2168
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: starter
>
> Add a {{HBaseTableSource}} to read data from a HBase table. The
> {{HBaseTableSource}} should implement the {{ProjectableTableSource}}
> (FLINK-3848) and {{FilterableTableSource}} (FLINK-3849) interfaces.
> The implementation can be based on Flink's {{TableInputFormat}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
