[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848086#comment-15848086
]
ASF GitHub Bot commented on FLINK-2168:
---------------------------------------
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/3149
> Regarding the HBaseTableSchema, we could also use it only internally and
not expose it to the user. The HBaseTableSource would have a method addColumn()
and forward the calls to its internal HBaseSchema.
Have done this. I initially thought to do things in the construction time
itself. Now added an addColumn() in hbaseTableSource. HBaseSchema becomes
totally package private and no access to users.
Regarding the flatSchema, generally in hbase only family is required and
the qualifiers are just dynamic. But here for the sake of accessibility we
expect the user to specify the column names. (trying to give a relational
look). It is in case of projections is where we have some issues. In my opinion
if we have a better API for Projection may be we could handle it better? The
current nested way as you said is better in the sense that all columns of a
family are grouped together.
> Add HBaseTableSource
> --------------------
>
> Key: FLINK-2168
> URL: https://issues.apache.org/jira/browse/FLINK-2168
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: starter
>
> Add a {{HBaseTableSource}} to read data from a HBase table. The
> {{HBaseTableSource}} should implement the {{ProjectableTableSource}}
> (FLINK-3848) and {{FilterableTableSource}} (FLINK-3849) interfaces.
> The implementation can be based on Flink's {{TableInputFormat}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
