mateczagany commented on code in PR #29265:
URL: https://github.com/apache/flink/pull/29265#discussion_r4069967205
##########
flink-end-to-end-tests/test-scripts/common_ssl.sh:
##########
@@ -79,6 +79,11 @@ function _set_conf_ssl_helper {
if [ "${provider}" = "OPENSSL" -a "${provider_lib}" = "dynamic" ]; then
cp $FLINK_DIR/opt/flink-shaded-netty-tcnative-dynamic-*.jar
$FLINK_DIR/lib/
+ # if the CI prepared a newer OpenSSL than the system one (see
e2e-template.yml), prefer it;
+ # local/developer runs without that variable set keep using the system
OpenSSL as before
+ if [ -n "${FLINK_E2E_OPENSSL32_LIB:-}" ]; then
+ export
LD_LIBRARY_PATH="${FLINK_E2E_OPENSSL32_LIB}${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}"
+ fi
elif [ "${provider}" = "OPENSSL" -a "${provider_lib}" = "static" ]; then
Review Comment:
The static path could also be imrpoved as it's now possible to also download
`flink-shaded-netty-tcnative-static` instead of compiling here. The version of
BoringSSL used in the newest flink-shaded versions contains Apache license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
