gaborgsomogyi commented on code in PR #29265:
URL: https://github.com/apache/flink/pull/29265#discussion_r4070062235
##########
flink-end-to-end-tests/test-scripts/common_ssl.sh:
##########
@@ -79,6 +79,11 @@ function _set_conf_ssl_helper {
if [ "${provider}" = "OPENSSL" -a "${provider_lib}" = "dynamic" ]; then
cp $FLINK_DIR/opt/flink-shaded-netty-tcnative-dynamic-*.jar
$FLINK_DIR/lib/
+ # if the CI prepared a newer OpenSSL than the system one (see
e2e-template.yml), prefer it;
+ # local/developer runs without that variable set keep using the system
OpenSSL as before
+ if [ -n "${FLINK_E2E_OPENSSL32_LIB:-}" ]; then
+ export
LD_LIBRARY_PATH="${FLINK_E2E_OPENSSL32_LIB}${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}"
+ fi
elif [ "${provider}" = "OPENSSL" -a "${provider_lib}" = "static" ]; then
Review Comment:
Two concerns with switching to the prebuilt artifact here:
1. Licensing: checked `LEGAL-393` (referenced in flink-shaded's own history
for this module). The ASF Legal discussion only cleared the dynamically-linked
variant ("option A"); static was never explicitly resolved, which is why it
stayed behind the opt-in profile since 2018.
2. Testing: building from source means this test always tracks the exact
`flink.shaded.version` tag, including unreleased changes to
`netty-tcnative-static` itself. A prebuilt download would only work once that
version is actually published on Maven Central, making it harder to test
flink-shaded changes to this module before release.
I'd rather keep the source build here for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
