MartijnVisser opened a new pull request, #243:
URL: https://github.com/apache/flink-connector-jdbc/pull/243
## What is the purpose of the change
- `PreparedSplitterEnumerator.of(sqlTemplate)` built the enumerator with an
empty parameter matrix, so a query without parameters produced no split and the
source finished without reading a row. It is the first example in the
`JdbcSourceBuilder` javadoc.
## Brief change log
- `of(sqlTemplate)` builds one empty parameter row, which the split reader
binds as no parameters
- `SqlSplitterEnumerator` is unchanged: an empty matrix still gives no
split, which `SlideTimingSplitterEnumerator` relies on between windows
- new `PreparedSplitterEnumeratorTest`
## Verifying this change
This change added tests and can be verified as follows:
- `PreparedSplitterEnumeratorTest` fails on `main` with `Expected size: 1
but was: 0` and passes with the change
- `SlideTimingSplitterEnumeratorTest`, `JdbcSourceITCase` and
`JdbcSourceStreamRelatedITCase` pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Fable 5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
