MartijnVisser opened a new pull request, #241:
URL: https://github.com/apache/flink-connector-jdbc/pull/241
## What is the purpose of the change
- Remove the InputFormat and OutputFormat classes nothing in the connector
uses. `JdbcRowOutputFormat` is public `@Experimental` and goes without a
deprecation cycle: it has not been a Flink `OutputFormat` since 3.2.0
(FLINK-31332). Release note on the Jira.
## Brief change log
- Delete `JdbcInputFormat`, `JdbcRowDataInputFormat`, `JdbcRowOutputFormat`,
`RowJdbcOutputFormat`, `TableJdbcUpsertOutputFormat`,
`InsertOrUpdateJdbcExecutor` and `KeyedBatchStatementExecutor` with their tests
- Rebuild the `ClassCastException` test from `JdbcFullTest` as
`JdbcOutputFormatRowTest`
- Move `JdbcAppendOnlyWriterTest` onto `JdbcOutputFormatBuilder`
- Keep `JdbcTypeUtil` for PyFlink (FLINK-40745)
- `[hotfix]` commit: drop the dangling `XaFacade` link from the
`JdbcExactlyOnceOptions` Javadoc
## Verifying this change
This change added tests and can be verified as follows:
- `JdbcOutputFormatTest#testCloseBeforeOpen` keeps the FLINK-17544 guard
that went with `JdbcTableOutputFormatTest`; `JdbcOutputFormatRowTest` keeps the
`ClassCastException` case from `JdbcFullTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Fable 5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
