csurong commented on code in PR #29245: URL: https://github.com/apache/flink/pull/29245#discussion_r4090285459
########## flink-python/pyflink/dataframe/io.py: ########## @@ -16,15 +16,269 @@ # limitations under the License. ################################################################################ -from typing import Dict, Optional, Tuple +from typing import Dict, List, Optional, Tuple, Union from pyflink.dataframe.context import get_or_create_table_environment -from pyflink.dataframe.dataframe import DataFrame +from pyflink.dataframe.dataframe import DataFrame, _normalize_subset from pyflink.dataframe.datatype import DataType from pyflink.table import Schema, TableDescriptor from pyflink.util.api_stability_decorators import PublicEvolving -__all__ = ["read_generic"] +__all__ = ["read_generic", "read_json", "read_parquet"] + + +def _build_filesystem_options( Review Comment: Renamed the four arguments as suggested and made them keyword-only. Readers and writers now use the same helper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
