gguptp commented on code in PR #206: URL: https://github.com/apache/flink-connector-aws/pull/206#discussion_r4097787881
########## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/util/GlueTableUtils.java: ########## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog.glue.util; + +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.catalog.ObjectPath; +import org.apache.flink.table.types.DataType; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import software.amazon.awssdk.services.glue.model.Column; +import software.amazon.awssdk.services.glue.model.StorageDescriptor; +import software.amazon.awssdk.services.glue.model.Table; + +import java.util.Collections; +import java.util.List; +import java.util.Map; + +/** + * Utility class for working with Glue tables, including transforming Glue-specific metadata into + * Flink-compatible objects. + */ +public class GlueTableUtils { + + /** Logger for logging Glue table operations. */ + private static final Logger LOG = LoggerFactory.getLogger(GlueTableUtils.class); + + /** Glue type converter for type conversions between Flink and Glue types. */ + private final GlueTypeConverter glueTypeConverter; + + /** + * Constructor to initialize GlueTableUtils with a GlueTypeConverter. + * + * @param glueTypeConverter The GlueTypeConverter instance for type mapping. + */ + public GlueTableUtils(GlueTypeConverter glueTypeConverter) { + this.glueTypeConverter = glueTypeConverter; + } + + /** + * Builds a Glue StorageDescriptor from the given table properties, columns, and location. + * + * @param tableProperties Table properties for the Glue table. + * @param glueColumns Columns to be included in the StorageDescriptor. + * @param tableLocation Location of the Glue table. + * @return A newly built StorageDescriptor object. + */ + public StorageDescriptor buildStorageDescriptor( + Map<String, String> tableProperties, List<Column> glueColumns, String tableLocation) { + + return StorageDescriptor.builder().columns(glueColumns).location(tableLocation).build(); + } + + /** + * Extracts the table location based on the table properties and the table path. First, it + * checks for a location key from the connector registry. If no such key is found, it uses a + * default path based on the table path. + * + * @param tableProperties Table properties containing the connector and location. + * @param tablePath The Flink ObjectPath representing the table. + * @return The location of the Glue table. + */ + public String extractTableLocation(Map<String, String> tableProperties, ObjectPath tablePath) { + String connectorType = tableProperties.get("connector"); + if (connectorType != null) { + String locationKey = ConnectorRegistry.getLocationKey(connectorType); + if (locationKey != null && tableProperties.containsKey(locationKey)) { + String location = tableProperties.get(locationKey); + return location; + } + } + + String defaultLocation = + tablePath.getDatabaseName() + "/tables/" + tablePath.getObjectName(); + return defaultLocation; + } + + /** + * Converts a Flink column to a Glue column. The column's data type is converted using the + * GlueTypeConverter. + * + * @param flinkColumn The Flink column to be converted. + * @return The corresponding Glue column. + */ + public Column mapFlinkColumnToGlueColumn(org.apache.flink.table.catalog.Column flinkColumn) { Review Comment: we're only persisting column name and type, what if there are watermarks in the flink schema? they'll get lost on a read back from glue. Same with primary keys? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
